[0.7.x] Ensure 'node' has a fallback type when working with static import linters #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224
When using linters that are parsing and analysing imports from
package.jsonfiles within thenode_modulesdirectory, they may fail because the./inertia-helpersdo not, and never have, ship a CJS version.Because the tooling is using CJS, it cannot find an appropriate import to use and Node itself fails.
This PR adds a fallback entrypoint for
node. The entry point, as per the docs, may be CJS or MJS, thus we may just point to out existing MJS built assets.You can read more about entry points in the node docs: https://nodejs.org/docs/latest-v16.x/api/packages.html#package-entry-points