-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect server.host variable in hot file #25
Conversation
@jessarcher This resolves the issue if we've manually specified the host, Perhaps this small update would help? const host = configHost ?? (serverAddress === '127.0.0.1' ? 'localhost' : serverAddress) As an aside, I think we should also be setting |
Ahh, I see. I worry about specifying In terms of the |
Okay, I don't mind manually specifying localhost in my config, as long as the hot file picks that up (which is what the PR is currently doing) so good to go there. Re the __vite_ping thing, I wonder if that's more a side effect I end up seeing if the websocket connection fails, which is why I don't see it when setting the hmr host? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is part of a bigger story for @hailwood, but I like this PR in isolation. It makes sense that we respect a hard coded config when present.
This PR adds support for Vite's
server.host
setting when writing the address to the hot file.Fixes #23