Use "moduleResolution": "NodeNext" #257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
changed the title
Closed
|
Thank you so much for dropping by our Laravel world to help us out with the upgrade, @sapphi-red. We've got a working branch where we have already made the type module changes, thankfully. I'm going to close this one as we I'm creating a single PR to house all our Vite 5 upgrade work to make it easier for review etc. Thanks again. We really appreciate the Vite team ❤️ |
|
No problem! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite 5 uses Rollup 4 and Rollup 4 now requires "moduleResolution": "NodeNext" or "moduleResolution": "bundler".
I set
"type": "module"inpackage.jsonto make it work, but I can renamesrc/index.tstosrc/index.mtsinstead of that. Setting"type": "module"will fixinertia-helpersto be interpreted as CJS too.