TypeScript: define entrypoints using object #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vite & Rollup use the type
InputOption
for input entrypoints (Rollup docs). The type definition is below (source):However, the Laravel Vite Plugin currently only supports the type
string | string[]
for its input entrypoints.This PR changes the
input
andssr
fields to use Rollup'sInputOption
, enabling users to specify the names of their entrypoint's output files. This behavior is already supported by the Laravel Vite Plugin, but TypeScript currently shows warnings invite.config.ts
when an object is used to specify entrypoints in theinput
orssr
fields.Here is what it looks like to specify output filenames using an object in Vite:
The PR also adds tests to ensure that the
input
andssr
fields will accept a string, array of strings, and input object.