-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:[LAR-60] Add send mail for decline article and fix unsend mail f… #156
feat:[LAR-60] Add send mail for decline article and fix unsend mail f… #156
Conversation
Corrige les soucis de phpstan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il vient d'ou ce fichier? Et ou est-il utilisé dans la PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dans la modal tu rejet c'est l'input du motif de rejet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi avoir créer ce composant ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi la création de ce composant ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vu que sur la plupart des projets nous partons sur la base des composants, je me suis permis d'en créer un pour chaque élément label, textaerea et input dans le dossier forms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu es entrain de bosser dans un site qui existe, qui a des formulaires qui a des inputs, tu ne cherches pas a fouiller une page (login / register) pour voir quels inputs sont utilisé. Tu pars prendre des inputs qui n'ont pas le même style le même design que ce qui est déjà utilisé
Ou est le test de cette fonctionnalité? |
…or approve article