laravelio · driesvints · Dec 14, 2021 · Dec 2, 2021
diff --git a/app/Events/ArticleWasApproved.php b/app/Events/ArticleWasApproved.php
@@ -9,10 +9,8 @@ final class ArticleWasApproved
 {
     use SerializesModels;
 
-    public $article;
-
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        public Article $article
+    ) {
     }
 }
diff --git a/app/Events/ArticleWasSubmittedForApproval.php b/app/Events/ArticleWasSubmittedForApproval.php
@@ -9,10 +9,8 @@ class ArticleWasSubmittedForApproval
 {
     use SerializesModels;
 
-    public $article;
-
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        public Article $article
+    ) {
     }
 }
diff --git a/app/Events/EmailAddressWasChanged.php b/app/Events/EmailAddressWasChanged.php
@@ -11,13 +11,8 @@ class EmailAddressWasChanged
     use Dispatchable;
     use SerializesModels;
 
-    /**
-     * @var \App\Models\User
-     */
-    public $user;
-
-    public function __construct(User $user)
-    {
-        $this->user = $user;
+    public function __construct(
+        public User $user
+    ) {
     }
 }
diff --git a/app/Events/ReplyWasCreated.php b/app/Events/ReplyWasCreated.php
@@ -9,13 +9,8 @@ final class ReplyWasCreated
 {
     use SerializesModels;
 
-    /**
-     * @var \App\Models\Reply
-     */
-    public $reply;
-
-    public function __construct(Reply $reply)
-    {
-        $this->reply = $reply;
+    public function __construct(
+        public Reply $reply
+    ) {
     }
 }
diff --git a/app/Jobs/ApproveArticle.php b/app/Jobs/ApproveArticle.php
@@ -8,11 +8,9 @@
 
 final class ApproveArticle
 {
-    private $article;
-
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        private Article $article
+    ) {
     }
 
     public function handle(): Article

diff --git a/app/Jobs/BanUser.php b/app/Jobs/BanUser.php
@@ -7,14 +7,9 @@
 
 final class BanUser
 {
-    /**
-     * @var \App\Models\User
-     */
-    private $user;
-
-    public function __construct(User $user)
-    {
-        $this->user = $user;
+    public function __construct(
+        private User $user
+    ) {
     }
 
     public function handle(): User

diff --git a/app/Jobs/CreateArticle.php b/app/Jobs/CreateArticle.php
@@ -9,24 +9,17 @@
 
 final class CreateArticle
 {
-    private $title;
-
-    private $body;
-
-    private $author;
-
-    private $shouldBeSubmitted;
-
     private $originalUrl;
 
     private $tags;
 
-    public function __construct(string $title, string $body, User $author, bool $shouldBeSubmitted, array $options = [])
-    {
-        $this->title = $title;
-        $this->body = $body;
-        $this->author = $author;
-        $this->shouldBeSubmitted = $shouldBeSubmitted;
+    public function __construct(
+        private string $title,
+        private string $body,
+        private User $author,
+        private bool $shouldBeSubmitted,
+        array $options = []
+    ) {
         $this->originalUrl = $options['original_url'] ?? null;
         $this->tags = $options['tags'] ?? [];
     }

diff --git a/app/Jobs/CreateReply.php b/app/Jobs/CreateReply.php
@@ -13,26 +13,11 @@
 
 final class CreateReply
 {
-    /**
-     * @var string
-     */
-    private $body;
-
-    /**
-     * @var \App\Models\User
-     */
-    private $author;
-
-    /**
-     * @var \App\Models\ReplyAble
-     */
-    private $replyAble;
-
-    public function __construct(string $body, User $author, ReplyAble $replyAble)
-    {
-        $this->body = $body;
-        $this->author = $author;
-        $this->replyAble = $replyAble;
+    public function __construct(
+        private string $body,
+        private User $author,
+        private ReplyAble $replyAble
+    ) {
     }
 
     public static function fromRequest(CreateReplyRequest $request): self

diff --git a/app/Jobs/CreateThread.php b/app/Jobs/CreateThread.php
@@ -10,32 +10,12 @@
 
 final class CreateThread
 {
-    /**
-     * @var string
-     */
-    private $subject;
-
-    /**
-     * @var string
-     */
-    private $body;
-
-    /**
-     * @var \App\Models\User
-     */
-    private $author;
-
-    /**
-     * @var array
-     */
-    private $tags;
-
-    public function __construct(string $subject, string $body, User $author, array $tags = [])
-    {
-        $this->subject = $subject;
-        $this->body = $body;
-        $this->author = $author;
-        $this->tags = $tags;
+    public function __construct(
+        private string $subject,
+        private string $body,
+        private User $author,
+        private array $tags = []
+    ) {
     }
 
     public static function fromRequest(ThreadRequest $request): self

diff --git a/app/Jobs/DeclineArticle.php b/app/Jobs/DeclineArticle.php
@@ -6,11 +6,9 @@
 
 final class DeclineArticle
 {
-    private Article $article;
-
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        private Article $article
+    ) {
     }
 
     public function handle(): void

diff --git a/app/Jobs/DeleteArticle.php b/app/Jobs/DeleteArticle.php
@@ -6,11 +6,9 @@
 
 final class DeleteArticle
 {
-    private $article;
-
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        private Article $article
+    ) {
     }
 
     public function handle()

diff --git a/app/Jobs/DeleteReply.php b/app/Jobs/DeleteReply.php
@@ -6,14 +6,9 @@
 
 final class DeleteReply
 {
-    /**
-     * @var \App\Models\Reply
-     */
-    private $reply;
-
-    public function __construct(Reply $reply)
-    {
-        $this->reply = $reply;
+    public function __construct(
+        private Reply $reply
+    ) {
     }
 
     public function handle()

diff --git a/app/Jobs/DeleteThread.php b/app/Jobs/DeleteThread.php
@@ -6,14 +6,9 @@
 
 final class DeleteThread
 {
-    /**
-     * @var \App\Models\Thread
-     */
-    private $thread;
-
-    public function __construct(Thread $thread)
-    {
-        $this->thread = $thread;
+    public function __construct(
+        private Thread $thread
+    ) {
     }
 
     public function handle()

diff --git a/app/Jobs/DeleteUser.php b/app/Jobs/DeleteUser.php
@@ -6,14 +6,9 @@
 
 final class DeleteUser
 {
-    /**
-     * @var \App\Models\User
-     */
-    private $user;
-
-    public function __construct(User $user)
-    {
-        $this->user = $user;
+    public function __construct(
+        private User $user
+    ) {
     }
 
     public function handle()

diff --git a/app/Jobs/DisapproveArticle.php b/app/Jobs/DisapproveArticle.php
@@ -6,14 +6,9 @@
 
 final class DisapproveArticle
 {
-    /**
-     * @var \App\Models\Article
-     */
-    private $article;
-
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        private Article $article
+    ) {
     }
 
     public function handle(): Article

diff --git a/app/Jobs/GenerateSocialShareImage.php b/app/Jobs/GenerateSocialShareImage.php
@@ -7,11 +7,6 @@
 
 final class GenerateSocialShareImage
 {
-    /**
-     * @var \App\Models\Thread
-     */
-    private $article;
-
     const TEXT_X_POSITION = 50;
 
     const TEXT_Y_POSITION = 100;
@@ -28,9 +23,9 @@ final class GenerateSocialShareImage
 
     const CACHE_LIFETIME = 43200;
 
-    public function __construct(Article $article)
-    {
-        $this->article = $article;
+    public function __construct(
+        private Article $article
+    ) {
     }
 
     public function handle(ImageManager $image)

diff --git a/app/Jobs/LikeArticle.php b/app/Jobs/LikeArticle.php
@@ -8,20 +8,10 @@
 
 final class LikeArticle
 {
-    /**
-     * @var \App\Models\Article
-     */
-    private $article;
-
-    /**
-     * @var \App\Models\User
-     */
-    private $user;
-
-    public function __construct(Article $article, User $user)
-    {
-        $this->article = $article;
-        $this->user = $user;
+    public function __construct(
+        private Article $article,
+        private User $user
+    ) {
     }
 
     /**

diff --git a/app/Jobs/LikeReply.php b/app/Jobs/LikeReply.php
@@ -8,20 +8,10 @@
 
 final class LikeReply
 {
-    /**
-     * @var \App\Models\Reply
-     */
-    private $reply;
-
-    /**
-     * @var \App\Models\User
-     */
-    private $user;
-
-    public function __construct(Reply $reply, User $user)
-    {
-        $this->reply = $reply;
-        $this->user = $user;
+    public function __construct(
+        private Reply $reply,
+        private User $user
+    ) {
     }
 
     /**

diff --git a/app/Jobs/LikeThread.php b/app/Jobs/LikeThread.php
@@ -8,20 +8,10 @@
 
 final class LikeThread
 {
-    /**
-     * @var \App\Models\Thread
-     */
-    private $thread;
-
-    /**
-     * @var \App\Models\User
-     */
-    private $user;
-
-    public function __construct(Thread $thread, User $user)
-    {
-        $this->thread = $thread;
-        $this->user = $user;
+    public function __construct(
+        private Thread $thread,
+        private User $user
+    ) {
     }
 
     /**