Improve logic and performance #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmishra01
commented
Dec 6, 2022
| init = [[x] for x in lists[0]] | ||
| return reduce(lambda a,b: [i+[j] for i in a for j in b], lists[1:], init) | ||
|
|
||
| return list(product(*lists)) |
There was a problem hiding this comment.
For combine_alternatives method, more cleaner approach.
lark/utils.py
Outdated
| else: | ||
| false_elems.append(elem) | ||
|
|
||
| true_elems = [elem for elem in seq if pred(elem) or false_elems.append(elem)] |
There was a problem hiding this comment.
Performance improve, if use list comprehension. Please check attached file.
jmishra01
force-pushed
the
lark-utils
branch
2 times, most recently
from
7b0f809
to
de37fae
Compare
use fromkeys
|
Looks good to me. @MegaIng , any objections? |
MegaIng
approved these changes
Dec 9, 2022
|
@jmishra01 Thanks for contributing! I hope it was more fun than painful 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor some code in utils file for better performance.