Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[M:grammar.md] doc: added Python-style comments. #1245

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

vincent-hugot
Copy link
Contributor

To go with #1230 .

Cheers

@vincent-hugot
Copy link
Contributor Author

Actually, though the change is trivial, since it affects syntax, should the doc mention the version in which # became valid, to avoid confusion from users reading the doc online but with an older version of Lark installed?

@erezsh
Copy link
Member

erezsh commented Jan 31, 2023

Hmm yeah, that's probably a good idea to mention it's starting from version 1.1.6

@vincent-hugot
Copy link
Contributor Author

Done.

Not sure why github bugs me with an email about ".github/workflows/codecov.yml: No jobs were run" upon pushing 😕

@erezsh erezsh merged commit c9b697e into lark-parser:master Jan 31, 2023
@erezsh
Copy link
Member

erezsh commented Jan 31, 2023

Thanks!

Not sure why github bugs me with an email about ".github/workflows/codecov.yml: No jobs were run" upon pushing

It's just badly configured, used to work but now broken. I was too lazy to fix it, but maybe I should get it out of the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants