Update config and drop python < 3.8 #1430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of 2 parts:
It removes python code specific to python 3.6/3.7 (and some only relevant for 2.7 that we forgot!)
It updates quite a bit config, although it's little "real" changes. I list them here as checkboxes so that you @erezsh can check them off if you agree with them
Since version 1.2, only Python versions 3.8 and up are supported
, so we should increment the version when this is released.3.13-dev
to the tests workflowpypy-3.7
topypy-3.10
in the tests workflow.pytest.ini
intopyproject.toml
, with the goal of reducing the number of config files we have. I didn't do the same fortox.ini
because it would just be putting the raw.ini
file into a multiline string, which seems too weird for me.unused-ignore
to the error codes for mypy which tells us when we can drop anignore
(I also dropped a few ignores based on this warning)types-regex
version. This is no longer necessary with us dropping python <3.8mypy
to1.10
instead of0.950
. Pinning is probably a good idea in general, but everything works with the current version, so no reason I know to keep an older version.fail_ci_if_error
incodecov.yml
fromtrue
tofalse
. This is primarily a selfish change, since it's very annoying to always get failed CI on my repo since I don't have the secret set. If you don't like this version, there is also a way to conditionally execute the workflow which would be an alternative solution.