Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Rephrase v_args() documentation to underline it only applies to Transformer classes #1458

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

skepppy
Copy link

@skepppy skepppy commented Aug 29, 2024

Related to issue #1457, rewording the documentation of v_args() to specify it is only applicable to Transformer classes.

@erezsh
Copy link
Member

erezsh commented Aug 29, 2024

I think we should avoid using the word visitor at all, when the Visitor class isn't involved, because it is confusing. I think it's best to just refer to them as callbacks, or transformer callbacks.

@erezsh erezsh changed the title Rephrase v_args() documentation to underline it is related to Transformer classes only Docs: Rephrase v_args() documentation to underline it only applies to Transformer classes Aug 29, 2024
@erezsh erezsh added the docs label Aug 29, 2024
@skepppy
Copy link
Author

skepppy commented Aug 29, 2024

I reworded it again, removing the references to visitor.

@erezsh erezsh merged commit 414e40f into lark-parser:master Aug 29, 2024
9 checks passed
@erezsh
Copy link
Member

erezsh commented Aug 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants