Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows build of grouped convolutions. #656

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Fix windows build of grouped convolutions. #656

merged 1 commit into from
Jun 9, 2021

Conversation

Tombana
Copy link
Collaborator

@Tombana Tombana commented Jun 9, 2021

What do these changes do?

This fixes the windows builds of #551

How Has This Been Tested?

Tested locally.

@Tombana Tombana requested a review from a team June 9, 2021 10:35
AdamHillier
AdamHillier approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@AdamHillier AdamHillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom!

@lgeiger lgeiger enabled auto-merge (squash) June 9, 2021 10:37
@lgeiger lgeiger merged commit 1daeac0 into main Jun 9, 2021
@lgeiger lgeiger deleted the fix_windows_grouped_convs branch June 9, 2021 10:56
@AdamHillier AdamHillier added the bug Something isn't working label Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamHillier AdamHillier AdamHillier approved these changes

@lgeiger lgeiger lgeiger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tombana @AdamHillier @lgeiger