-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Pydantic 2+ or drop pydantic #1075
Milestone
Comments
gdementen
added a commit
to gdementen/larray
that referenced
this issue
Sep 14, 2023
This is a workaround until we add proper support for v2 (see larray-project#1075)
gdementen
added a commit
that referenced
this issue
Sep 14, 2023
This is a workaround until we add proper support for v2 (see #1075)
FWIW, here are the pro and cons of pydantic (v2) vs our own solution: Pros:
Cons:
I would say that, in the end, if we only ever want to support the current feature-set with only runtime checking of axes, a custom solution would be less (maintenance) work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pydantic2 has been released in june 2023 and it is a massive change compared to v1. There is even a whole migration guide at:
https://docs.pydantic.dev/2.0/migration/
Needless to say, larray is not compatible with it. We should either rewrite Checked* using v2, or stop using Pydantic at all (I have some proof of concept code doing this somewhere).
PS: CI is not failing on this (yet) because anaconda packages for Pydantic are still at v1. But I noticed the error via readthedocs where pydantic is installed via pip instead.
The text was updated successfully, but these errors were encountered: