(issue 744): use pythonic notation in doc of aggregation functions #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/larray-project/larray/pull/771 Visit www.reviewnb.com to know how we simplify your Jupyter Notebook workflows. |
gdementen
reviewed
Jun 7, 2019
larray/example.py
Outdated
| title: Demographic datasets for a small selection of countries in Europe | ||
| source: demo_jpan, demo_fasec, demo_magec and demo_marcz tables from Eurostat | ||
| citizenship: citizenship ['TOTAL' 'NAT' 'FOR' 'STLS' 'UNK'] (5) | ||
| country: country ['Belgium' 'France' 'Germany'] (3) |
There was a problem hiding this comment.
The representation for axes in .summary seems odd. Why do we repeat the axis name? Aslo, couldn't we make that clearer by grouping objects by type. eg:
Metadata:
...
Arrays:
...
Axes:
...
Groups:
...
Closed
alixdamman
force-pushed
the
744_use_pythonic_notation_in_doc
branch
2 times, most recently
from
822e922
to
f439684
Compare
…n function examples
alixdamman
force-pushed
the
744_use_pythonic_notation_in_doc
branch
from
f439684
to
aef1580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.