Use filter fn #25
Merged
Use filter fn #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, will also implement the double |
mxinden
force-pushed
the
feat-dplpmtud
branch
2 times, most recently
from
4b195a0 to
32635f5
Compare
mxinden
commented
Jul 10, 2024
| where | ||
| I: Iterator<Item = &'a SentPacket>, | ||
| { | ||
| lost_packets: impl IntoIterator<Item = &'a SentPacket>, |
There was a problem hiding this comment.
Using IntoIterator instead of Iterator allows other code to still pass a Vec, thus reducing the diff of the pull request.
| where | ||
| I: Iterator<Item = &'a SentPacket>, | ||
| { | ||
| lost_packets: impl IntoIterator<Item = &'a SentPacket>, |
There was a problem hiding this comment.
impl XXX is just suggar code for a proper where block declaration.
Follow-up on mozilla#1903 (comment)
larseggert
approved these changes
Jul 10, 2024
larseggert
reviewed
Jul 10, 2024
| /// Allows filtering packets without holding a reference to [`Pmtud`]. When | ||
| /// in doubt, use [`Pmtud::is_pmtud_probe`]. | ||
| pub fn is_probe_filter(&self) -> impl Fn(&SentPacket) -> bool { | ||
| let probe_state = Probe::Sent; |
There was a problem hiding this comment.
@mxinden This would need to be let probe_state = self.probe_state;, and then I again get borrow checker issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on mozilla#1903 (comment)