Fixed it #29
Merged
Fixed it #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
commented
Aug 20, 2024
| ZeroRttState::AcceptedServer | ||
| } | ||
| _ => ZeroRttState::Rejected, | ||
| self.zero_rtt_state = if self.crypto.enable_0rtt(self.version, self.role) == Ok(true) { |
There was a problem hiding this comment.
This is just factoring and more logging.
| @@ -53,7 +53,7 @@ pub fn fixture_init() { | |||
|
|
|||
| // This needs to be > 2ms to avoid it being rounded to zero. | |||
| // NSS operates in milliseconds and halves any value it is provided. | |||
| pub const ANTI_REPLAY_WINDOW: Duration = Duration::from_millis(10); | |||
| pub const ANTI_REPLAY_WINDOW: Duration = Duration::from_millis(10000); | |||
There was a problem hiding this comment.
This is the real fix.
NSS estimates the RTT. There is a very small allowance for dropped packets and variations in network delay. The test you wrote added a bunch of extra delay that looked - at least to NSS - like additional delays.
larseggert
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.