Fix runpath check for ensemble experiment

src/ert/run_models/ensemble_experiment.py

@@ -3,6 +3,7 @@
 import asyncio
 import concurrent
 import logging
+from pathlib import Path
 from typing import TYPE_CHECKING, Any, Dict
 from uuid import UUID
 
@@ -169,3 +170,10 @@ def run_experiment(
  @classmethod
  def name(cls) -> str:
  return "Ensemble experiment"
+
+ def check_if_runpath_exists(self) -> bool:
+ iteration = self._simulation_arguments.get("iter_num", 0)
+ active_mask = self._simulation_arguments.get("active_realizations", [])
+ active_realizations = [i for i in range(len(active_mask)) if active_mask[i]]
+ run_paths = self.facade.get_run_paths(active_realizations, iteration)
+ return any(Path(run_path).exists() for run_path in run_paths)

tests/unit_tests/run_models/conftest.py

@@ -0,0 +1,15 @@
+import os
+
+import pytest
+
+
+@pytest.fixture
+def create_dummy_run_path(tmpdir):
+ run_path = os.path.join(tmpdir, "out")
+ os.mkdir(run_path)
+ os.mkdir(os.path.join(run_path, "realization-0"))
+ os.mkdir(os.path.join(run_path, "realization-0/iter-0"))
+ os.mkdir(os.path.join(run_path, "realization-1"))
+ os.mkdir(os.path.join(run_path, "realization-1/iter-0"))
+ os.mkdir(os.path.join(run_path, "realization-1/iter-1"))
+ yield os.chdir(tmpdir)

tests/unit_tests/models/test_base_run_model.py → tests/unit_tests/run_models/test_base_run_model.py

@@ -1,4 +1,3 @@
-import os
 from unittest.mock import MagicMock
 from uuid import UUID
 
@@ -73,18 +72,6 @@ def test_run_ensemble_evaluator():
  run_context.deactivate_realization.assert_called_with(0)
 
 
-@pytest.fixture
-def create_dummy_run_path(tmpdir):
- run_path = os.path.join(tmpdir, "out")
- os.mkdir(run_path)
- os.mkdir(os.path.join(run_path, "realization-0"))
- os.mkdir(os.path.join(run_path, "realization-0/iter-0"))
- os.mkdir(os.path.join(run_path, "realization-1"))
- os.mkdir(os.path.join(run_path, "realization-1/iter-0"))
- os.mkdir(os.path.join(run_path, "realization-1/iter-1"))
- yield os.chdir(tmpdir)
-
-
 @pytest.mark.parametrize(
  "run_path, number_of_iterations, start_iteration, active_mask, expected",
  [
@@ -116,11 +103,9 @@ def get_run_path_mock(realizations, iteration=None):
  return [f"out/realization-{r}" for r in realizations]
 
  brm = BaseRunModel(simulation_arguments, None, None, None, None)
-
  brm.facade = MagicMock(
  run_path=run_path,
  number_of_iterations=number_of_iterations,
  get_run_paths=get_run_path_mock,
  )
-
  assert brm.check_if_runpath_exists() == expected

tests/unit_tests/run_models/test_ensemble_experiment.py

@@ -0,0 +1,48 @@
+from unittest.mock import MagicMock
+
+import pytest
+
+from ert.run_models import EnsembleExperiment
+
+
+@pytest.mark.parametrize(
+ "run_path, number_of_iterations, iter_num, active_mask, expected",
+ [
+ ("out/realization-%d/iter-%d", 4, 2, [True, True, True, True], False),
+ ("out/realization-%d/iter-%d", 4, 1, [True, True, True, True], True),
+ ("out/realization-%d/iter-%d", 4, 1, [False, False, True, False], False),
+ ("out/realization-%d/iter-%d", 4, 0, [False, False, False, False], False),
+ ("out/realization-%d/iter-%d", 4, 0, [], False),
+ ("out/realization-%d", 2, 1, [False, True, True], True),
+ ("out/realization-%d", 2, 0, [False, False, True], False),
+ ],
+)
+def test_check_if_runpath_exists(
+ create_dummy_run_path,
+ run_path: str,
+ number_of_iterations: int,
+ iter_num: int,
+ active_mask: list,
+ expected: bool,
+):
+ simulation_arguments = {
+ "iter_num": iter_num,
+ "active_realizations": active_mask,
+ }
+
+ def get_run_path_mock(realizations, iteration=None):
+ if iteration is not None:
+ return [f"out/realization-{r}/iter-{iteration}" for r in realizations]
+ return [f"out/realization-{r}" for r in realizations]
+
+ ensemble_experiment = EnsembleExperiment(
+ simulation_arguments, None, None, None, None
+ )
+
+ ensemble_experiment.facade = MagicMock(
+ run_path=run_path,
+ number_of_iterations=number_of_iterations,
+ get_run_paths=get_run_path_mock,
+ )
+
+ assert ensemble_experiment.check_if_runpath_exists() == expected