Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bootstrap4 #73

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

44uk
Copy link

@44uk 44uk commented Jul 11, 2016

Add class for fragment and bootstrap4 style.

@44uk 44uk changed the title Support bootstrap4 alpha Support bootstrap4 alpha.2 Jul 11, 2016
@44uk
Copy link
Author

44uk commented Jul 13, 2016

Failing Travis CI by Rails 4.x on Ruby 1.9.3, what should I do for all green?

@MrShemek
Copy link

MrShemek commented Dec 7, 2016

+1

MrShemek added a commit to OnTheGoSystems/gretel that referenced this pull request Dec 8, 2016
MrShemek added a commit to OnTheGoSystems/gretel that referenced this pull request Dec 8, 2016
@h6ah4i
Copy link

h6ah4i commented May 11, 2017

+1

I also need this feature for spectre.css. It has the same syntax with Bootstrap 4.

<ul class="breadcrumb">
  <li class="breadcrumb-item">
    <a href="#">
      Home
    </a>
  </li>
  <li class="breadcrumb-item">
    <a href="#">
      Profile
    </a>
  </li>
  <li class="breadcrumb-item">
    Change avatar
  </li>
</ul>

ref.) https://picturepan2.github.io/spectre/components.html#navigation

@44uk
Copy link
Author

44uk commented May 11, 2017

What we really need may be supporting fragment class.

@czj
Copy link

czj commented Aug 18, 2017

Hi!

@WilHall as Ruby 2.0 support has ended we should probably remove it from Travis CI. Could you please do that so @44uk 's tests can pass ?

@WilHall could you please merge it afterwards ? We love Gretel and being able to upgrade to Bootstrap 4 beta 1 with it would be appreciated 👍

@44uk 44uk changed the title Support bootstrap4 alpha.2 Support bootstrap4 Aug 21, 2017
@44uk
Copy link
Author

44uk commented Aug 21, 2017

bootstrap v4.0.0-beta had been released. but no need to change.
https://getbootstrap.com/docs/4.0/components/breadcrumb/

@mkasztelnik
Copy link

@44uk since this repo is not maintained anymore can you submit this PR into https://github.com/WilHall/gretel (soon-to-be) active fork?

@44uk
Copy link
Author

44uk commented Nov 9, 2018

@mkasztelnik Thank you for the advice. I'll check updated bootstrap(Currently v4.1.3 released) and do PR to the fork.

@czj
Copy link

czj commented Nov 9, 2018

@mkasztelnik thank you for your work.

Will https://github.com/WilHall/gretel be the repo from which the gem is built from now on ?

@MrShemek
Copy link

MrShemek commented Nov 9, 2018

@czj yes, together with @WilHall we are going to maintain the gem again.

@czj
Copy link

czj commented Nov 9, 2018

Awesome @MrShemek :-) We'll gladly help if we can @levups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants