-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bootstrap4 #73
base: master
Are you sure you want to change the base?
Conversation
Failing Travis CI by Rails 4.x on Ruby 1.9.3, what should I do for all green? |
+1 |
(code-updates) Changes from lassebunk#73 & lassebunk#78 pull requests
+1 I also need this feature for spectre.css. It has the same syntax with Bootstrap 4. <ul class="breadcrumb">
<li class="breadcrumb-item">
<a href="#">
Home
</a>
</li>
<li class="breadcrumb-item">
<a href="#">
Profile
</a>
</li>
<li class="breadcrumb-item">
Change avatar
</li>
</ul> ref.) https://picturepan2.github.io/spectre/components.html#navigation |
What we really need may be supporting fragment class. |
Hi! @WilHall as Ruby 2.0 support has ended we should probably remove it from Travis CI. Could you please do that so @44uk 's tests can pass ? @WilHall could you please merge it afterwards ? We love Gretel and being able to upgrade to Bootstrap 4 beta 1 with it would be appreciated 👍 |
bootstrap v4.0.0-beta had been released. but no need to change. |
@44uk since this repo is not maintained anymore can you submit this PR into https://github.com/WilHall/gretel (soon-to-be) active fork? |
@mkasztelnik Thank you for the advice. I'll check updated bootstrap(Currently v4.1.3 released) and do PR to the fork. |
@mkasztelnik thank you for your work. Will https://github.com/WilHall/gretel be the repo from which the gem is built from now on ? |
Add class for fragment and bootstrap4 style.