Added support for phone, address and questions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param Mixed String|Array | ||
| */ | ||
| public function addQuestion($path, $question, $answer) { | ||
| $answers = !is_array($answer) ? [['id' => '', 'text' => $answer]] : $answer; |
There was a problem hiding this comment.
It's best not to use boolean inversions if not necessary (i.e. remove the '!')
|
comment blocks should start with a /** instead of a /* to take advantage of PHPdoc |
|
I will be taking over changes to this pull request |
|
Please don't merge until squashed - if you're happy with these changes, let me know to squash first before you merge |
| /* These variables should only be attached to the request on the server side */ | ||
| $clientId = 19; | ||
| $projectId = 6; | ||
| /** |
There was a problem hiding this comment.
Use '/*' for comment blocks that aren't phpdoc
tutfoo
force-pushed
the
example-submitter
branch
from
b1fff5e
to
3261bff
Compare
|
Fixed /** to /* comments in signup.php and squashed. |
remove unused variables
postal code no longer set to state
| * primary: true | ||
| * } | ||
| */ | ||
| private $addresses; |
There was a problem hiding this comment.
Not initialized as an array, might be an issue with line 151
initialized address to array
added notes to the available fields
| $lassoUid = ''; | ||
| $apiKey = ''; | ||
|
|
||
| if (empty($clientId) || empty($projectId) || empty($apiKey)) { |
There was a problem hiding this comment.
I like this. Error messages should give hints how to fix said error.
trb
added a commit
that referenced
this pull request
Feb 27, 2016
Added support for phone, address and questions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@todo feedback on the register button
@todo error on missing required params (projectId, clientId, etc)
@todo make configuation more obvious