-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share Button [8/n] Show modal on UI click #1049
Conversation
Share Button [7/n]: Display loading UI Created a separate component for the shareButton to manage the `isLoading` state and show that in the UI ## Test Plan Rebase on then do: #1045 Go to `aiconfig/python/src/aiconfig/editor/client` and run this command: ``` rm -rf node_modules && yarn && yarn build ``` Then go to `aiconfig` dir and run this command: ``` aiconfig_path =./cookbooks/Gradio/huggingface.aiconfig.json parsers_path=./cookbooks/Gradio/hf_model_parsers.py aiconfig edit --aiconfig-path=$aiconfig_path --server-port=8080 --server-mode=debug_servers --parsers-module-path=$parsers_path ``` No Error Testing https://github.com/lastmile-ai/aiconfig/assets/151060367/1e9f4b90-a9e9-4c60-a813-afa2a46a1b5a Error Testing https://github.com/lastmile-ai/aiconfig/assets/151060367/1abcce37-8ba4-4513-b826-ea0f9d7bb720 --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1044). * #1045 * #1049 * __->__ #1044
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting to unblock, just minor things
python/src/aiconfig/editor/client/src/components/global/ShareButton.tsx
Outdated
Show resolved
Hide resolved
python/src/aiconfig/editor/client/src/components/global/ShareButton.tsx
Outdated
Show resolved
Hide resolved
python/src/aiconfig/editor/client/src/components/global/ShareButton.tsx
Outdated
Show resolved
Hide resolved
[theme.fn.smallerThan("sm")]: { | ||
marginLeft: "0", | ||
display: "block", | ||
position: "static", | ||
bottom: -10, | ||
left: 0, | ||
height: 28, | ||
margin: "10px 0", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this look like on small screens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't actually apply to us since we can never go smaller than certain width for some reason:
95d05cfd-3750-42c4-a770-e239c9af9bce.mp4
Showing the modal after button returns a URL. I'm pretty annoyed, wasn't able to get it: 1. Show up right beside the Share button 2. Have it look beautiful in the modal 3. Have the copy button be displayed on the right side (I was able to use position absolute, but now the label does not work and it's also not aligned with the padding for the X close button) ## Test plan https://github.com/lastmile-ai/aiconfig/assets/151060367/9fba2b38-0602-4a92-b77a-2d8624d8fe34
Published both pacakges to PyPi, also ran yarn build because I forgot to do that after #1049
Updating python-aiconfig to v1.1.17 and HF extension to 0.0.6 Published both pacakges to PyPi, also ran yarn build because I forgot to do that after #1049 Following instructions from https://www.notion.so/lastmile-ai/OSS-Release-process-Publishing-Guides-1260b4199f3946ff8abf5713f7c3fffc?pvs=4#b4ae95f609814f9095411c742391e915
Share Button [8/n] Show modal on UI click
Showing the modal after button returns a URL. I'm pretty annoyed, wasn't able to get it:
Test plan
46e13a39-64cf-40a7-9786-5fb78405e5f2.mp4
Stack created with Sapling. Best reviewed with ReviewStack.