[editor] Claude Bedrock Prompt Schema #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
Ankush-lastmile
force-pushed
the
pr1050
branch
from
3dacc12
to
add3e83
Compare
rossdanlm
approved these changes
Jan 29, 2024
| items: { | ||
| type: "string", | ||
| }, | ||
| description: `Sequences that will cause the model to stop generating.`, |
There was a problem hiding this comment.
Don't really understand this but that's fine, just from official documentation. As long as we have a good cookbook with local editor should be cool
There was a problem hiding this comment.
here's an example to help you visualize it
| description: `An object describing metadata about the request. (Claude specific)`, | ||
| } | ||
| }, | ||
| required: ["model", "max_tokens_to_sample", "stop_sequences"], |
| @@ -81,6 +82,8 @@ export const PROMPT_SCHEMAS: Record<string, PromptSchema> = { | |||
| "dall-e-2": DalleImageGenerationParserPromptSchema, | |||
| "dall-e-3": DalleImageGenerationParserPromptSchema, | |||
|
|
|||
| "ClaudeBedrockModelParser": ClaudeBedrockPromptSchema, | |||
There was a problem hiding this comment.
So just to be clear, the "model_name" is "Claude" when we register it in the core model parsers?
Do we also need to do "Claude": ClaudeBedrockPromptSchema?
There was a problem hiding this comment.
yes we would need to register it as well
There was a problem hiding this comment.
discussed offline, we'll get rid of "Claude" for now
added 2 commits
January 29, 2024 17:31
Model Parser for Claude on AWS Bedrock Claude on Bedrock can be called with the - `anthropic_bedrock` python library - AWS' `Boto3` Library - Chose to use the `anthropic_bedrock` library because it has good abstractions and type hints Claude on Bedrock only supports Text Completions, turn style [prompts are not supported](https://docs.anthropic.com/claude/reference/claude-on-amazon-bedrock#:~:text=Messages%20in%20Amazon%20Bedrock) - Added Claude model parser as a core parser. - added dependency on `anthropic_bedrock` ## Testplan using prompt schema from diff ontop https://github.com/lastmile-ai/aiconfig/assets/141073967/29c1faa7-7d13-412f-8606-9ad556eb1c52
Ankush-lastmile
force-pushed
the
pr1050
branch
from
add3e83
to
21d2574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[editor] Claude Bedrock Prompt Schema
Testplan
claude.testplan.mov
Stack created with Sapling. Best reviewed with ReviewStack.