[1/n] Add load_json and load_yaml methods to AIConfigRuntime #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saqadri
requested review from
rholinshead,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
This was referenced Jan 29, 2024
This was referenced Jan 29, 2024
Merged
Allow loading an AIConfigRuntime from a string. There's already a `loadJSON` method in the TS SDK.
This is needed for VSCode extension (top of stack), which gets the state of the document from the editor (and which can contain unsaved changes that aren't present on the filesystem).
Test Plan:
Tested out getting started ipynb with:
load JSON:
```
config = AIConfigRuntime.load('travel.aiconfig.json')
```
load YAML:
```
config.save('travel.aiconfig.yaml', mode="yaml")
yaml_str = ""
with open('travel.aiconfig.yaml') as file:
yaml_str = file.read()
config = AIConfigRuntime.load_yaml(yaml_str)
```
Made sure config runtime is valid and tried `config.run`
This was referenced Jan 30, 2024
saqadri
added a commit
that referenced
this pull request
Jan 30, 2024
[4/n] Add 'start' command to aiconfig server and CLI The current aiconfig CLI has an 'edit' command which starts both the frontend and backend servers, and also loads the aiconfig from disk. In the same vein, this diff introduces a 'start' command that is used to just start the aiconfig server. This is used by the vscode extension to spawn a server when an aiconfig file is opened. Unlike the 'edit' command, 'start': * Doesn't load the aiconfig on server init. Instead, the /api/load_content endpoint is called to initialize. * Doesn't search for open ports. The vscode client is responsible for finding an open port. This is because the client needs to be in control of the server lifecycle. A small change that was also added to this diff: using `dotenv` to load an env file. Test Plan: * At the top of stack --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1060). * #1076 * __->__ #1060 * #1059 * #1058 * #1057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1/n] Add load_json and load_yaml methods to AIConfigRuntime
Allow loading an AIConfigRuntime from a string. There's already a
loadJSONmethod in the TS SDK.This is needed for VSCode extension (top of stack), which gets the state of the document from the editor (and which can contain unsaved changes that aren't present on the filesystem).
Test Plan:
Tested out getting started ipynb with:
load JSON:
load YAML:
Made sure config runtime is valid and tried
config.runStack created with Sapling. Best reviewed with ReviewStack.