Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ez] Export missing default model parsers #1112

Merged
merged 1 commit into from
Feb 3, 2024
Merged

[ez] Export missing default model parsers #1112

merged 1 commit into from
Feb 3, 2024

Conversation

rossdanlm
Copy link
Contributor

@rossdanlm rossdanlm commented Feb 2, 2024

[ez] Export missing default model parsers

Now we can do from aiconfig import ClaudeBedrockModelParser for example. I also deleted the hf.py file since we now have aiconfig_extension_hugging_face for this


Stack created with Sapling. Best reviewed with ReviewStack.

Copy link
Contributor

@rholinshead rholinshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting changes for the HF mistral cookbook

Now we can do `from aiconfig import ClaudeBedrockModelParser` for example. I also deleted the `hf.py` file since we now have `aiconfig_extension_hugging_face` for this
@rossdanlm
Copy link
Contributor Author

Based on comments:

  1. Not removing core model parser for HF. Task for removing it in Remove core HF parser, use extension instead for HF cookbook #1116
  2. Not defining model parser for AzureOpenAIParser

@@ -53,13 +52,13 @@
ModelParserRegistry.register_model_parser(
DefaultAnyscaleEndpointParser("AnyscaleEndpoint")
)
ModelParserRegistry.register_model_parser(ClaudeBedrockModelParser())
for model in gpt_models_extra:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, would be better to have this colocate with the main registered ones above. Do you know why these are handled in a separate 'extra' array?

Copy link
Member

@Ankush-lastmile Ankush-lastmile Feb 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was implemented in #994 as a quick hack

@rossdanlm rossdanlm merged commit 51d300f into main Feb 3, 2024
4 checks passed
@rossdanlm rossdanlm deleted the pr1112 branch February 3, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants