[easy] Set Gemini model parser id to the model id being used #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
force-pushed
the
pr1139
branch
from
7786720
to
22f4347
Compare
added 2 commits
February 5, 2024 17:51
Gemini api under the hood saves a reference to the async event loop. This messes with the local editor because we create a new event loop on api/run. This diff reinitializes the "client" at the run step for the Gemini model parser. I put client in quotes because its not called a client but its analogous to the openai client abstraction. ## Testplan Run a gemini prompt twice inside local editor. Before: <img width="1598" alt="Screenshot 2024-02-05 at 5 36 26 PM" src="https://github.com/lastmile-ai/gradio-workbook/assets/141073967/5ed779f4-61b2-4595-a34c-11992a2c055c"> After: run twice, no event loop error https://github.com/lastmile-ai/gradio-workbook/assets/141073967/39d1d4b2-90c5-4ee1-b1a4-bc35d8528d60
Ankush-lastmile
force-pushed
the
pr1139
branch
from
22f4347
to
50cada2
Compare
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
saqadri
approved these changes
Feb 5, 2024
added comment Co-authored-by: Sarmad Qadri <sarmad.qadri@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[easy] Set Gemini model parser id to the model id being used
title
Stack created with Sapling. Best reviewed with ReviewStack.