[vscode install] 4/n add retry for pip install dependencies #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 22, 2024
Ankush-lastmile
added a commit
that referenced
this pull request
Feb 22, 2024
…nstall (#1265) [vscode installation] 2/n refactor error message for invalid python install Added a helper method for showing user friendly error when python install doesn't go well. ## Testplan Select Interpreter version 3.9.4. Open an editor and expect an error notification. https://github.com/lastmile-ai/aiconfig/assets/141073967/5bda86e0-690f-4e43-9e94-f9279e3b2f34 --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1265). * #1294 * #1289 * #1290 * __->__ #1265
added 2 commits
February 22, 2024 12:57
This diff updates the initialize flow to include the Python interpreter selection step. It ensures dependencies are installed only after the interpreter selection is finalized, accommodating the no-op change where the selected interpreter remains unchanged. Note: If the extension is not activated, invoking the Initialize AIConfig command for an unknown reason installs dependencies on the pre-selected interpreter path ## testplan Extension initializes on Opening An AIConfig Test select a new interpreter Test reselecting the same interpreter https://github.com/lastmile-ai/aiconfig/assets/141073967/1a51ff89-3889-4fd6-8964-c341453ddf68
Ankush-lastmile
changed the title
Ankush-lastmile
force-pushed
the
pr1294
branch
from
77fd16e
to
ea1664f
Compare
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
rholinshead
approved these changes
Feb 22, 2024
rholinshead
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vscode install] 4/n add retry for pip install dependencies
Stack created with Sapling. Best reviewed with ReviewStack.