1/n [vscode & server] Reload Environment when invoking the Run Step #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
changed the title
Ankush-lastmile
force-pushed
the
pr1376
branch
2 times, most recently
from
75fc0eb
to
5d5101f
Compare
This was
linked to
issues
Feb 27, 2024
rossdanlm
reviewed
Feb 27, 2024
Comment on lines
+334
to
+337
|
|
||
| # Allow user to modify their environment keys without reloading the server. | ||
| # Execution time of `0.001s` is arbitrary, but should be small enough to not be noticeable. | ||
| dotenv.load_dotenv() |
There was a problem hiding this comment.
We should consider just adding these to model parsers directly, but this moves us forwards and we can change that later if we want
rossdanlm
approved these changes
Feb 27, 2024
saqadri
requested review from
saqadri,
rholinshead,
suyoglastmileai and
jonathanlastmileai
as code owners
This diff modifies the AIConfig backend server to reload the environment everytime the Run Step is invoked. This will allow api keys that are newly added to be picked up from the aiconfig server, without the need to restart the server. I validated that `load_dotenv` does not add any noticeable latency. ``` import time import dotenv start = time.time() dotenv.load_dotenv() end = time.time() print(end-start) _____ 0.0010402202606201172s ``` Surfaced from #1371, a restart of the server will no longer be required. Ontop of this, we can pass a .env path directly the server initialization, instead of relying on a set of lowest-common-ancestor checks Discussed offline with @saqadri ## Testplan https://github.com/lastmile-ai/aiconfig/assets/141073967/c67cbb5c-785a-40b4-9aac-6cccfaff0004
Ankush-lastmile
force-pushed
the
pr1376
branch
from
5d5101f
to
868ac2f
Compare
Quick summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1/n [vscode & server] Reload Environment when invoking the Run Step
This diff modifies the AIConfig backend server to reload the environment everytime the Run Step is invoked. This will allow api keys that are newly added to be picked up from the aiconfig server, without the need to restart the server.
I validated that
load_dotenvdoes not add any noticeable latency.Surfaced from #1371, a restart of the server will no longer be required.
Ontop of this, we can pass a .env path directly the server initialization, instead of relying on a set of lowest-common-ancestor checks
Discussed offline with @saqadri
Testplan
testplan.mp4