[ci/cd] Python Formatting Check #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
force-pushed
the
pr1458
branch
2 times, most recently
from
54512b8
to
146c9fe
Compare
Ankush-lastmile
force-pushed
the
pr1458
branch
9 times, most recently
from
b9d7a48
to
eba83e5
Compare
added 2 commits
March 14, 2024 14:35
`black --exclude '/\.sl\b' . --line-length=79` A lot of the python files checked into the AIConfig repo have not been formatted. This command formats all python files the same way vscode would do it in the repo. I noticed differences between black version 23.11 and 24 (latest). I had version 23.11 on my local install. This also causes different behaviours when running autoformat through vscode instead of the command line, I'm fairly certain vscode extension uses its own package. I upgraded my black formatter local install to 24 (latest). Note: black is python package.
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci/cd] Python Formatting Check
blocks on merging
Stack created with Sapling. Best reviewed with ReviewStack.