[editor][server endpoints][2/n]: Add params arg to run command and check for undefined prompt_name #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
rholinshead
approved these changes
Dec 26, 2023
|
LGTM - fwiw I don't know that this will be needed for the editor since the params would be saved into the aiconfig when changed in the UI |
jonathanlastmileai
approved these changes
Dec 28, 2023
Comment on lines
122
to
130
| prompt_name : str = request_json.get("prompt_name", None) | ||
| if prompt_name is None: | ||
| return HttpResponseWithAIConfig( | ||
| message="No prompt name provided, cannot execute `run` command", | ||
| code=400, | ||
| aiconfig=None, | ||
| ).to_flask_format() | ||
| params : str = request_json.get("params", None) | ||
| stream : bool = request_json.get("stream", True) |
There was a problem hiding this comment.
nits:
prompt_name is a str | None
please use the linter and/or vscode for pyright + black formatting.
autofix just these files, one-liner:
fd --glob '*.py' python/src/aiconfig/editor/server | xargs python -m 'scripts.lint' --mode=fix --files
There was a problem hiding this comment.
Awesome thanks for the auto-fix command!
rossdanlm
pushed a commit
that referenced
this pull request
Dec 28, 2023
Not being used, let's get rid of it dawg! I also ran the linter based on Jonathan's command from this comment: #613 (comment) ``` fd --glob '*.py' python/src/aiconfig/editor/server | xargs python -m 'scripts.lint' --mode=fix --files ``` ^ (btw you can install fd on Mac using `brew install fd`, looks pretty cool). It actually seems pretty cool https://github.com/sharkdp/fd?tab=readme-ov-file
rossdanlm
added a commit
that referenced
this pull request
Dec 28, 2023
Remove declaration of generic T from server.py Not being used, let's get rid of it dawg! I also ran the linter based on Jonathan's command from this comment: #613 (comment) ``` fd --glob '*.py' python/src/aiconfig/editor/server | xargs python -m 'scripts.lint' --mode=fix --files ``` ^ (btw you can install fd on Mac using `brew install fd`, looks pretty cool). It actually seems pretty cool https://github.com/sharkdp/fd?tab=readme-ov-file
rossdanlm
changed the title
rossdanlm
force-pushed
the
pr613
branch
2 times, most recently
from
e0c8f59
to
43827ea
Compare
…eck for undefined prompt_name TSIA, pretty simple otherwise we'd be using empty params field and that would error. For the future, I created issue #671 where we shouldn't even need to pass in params into run and this works implicitly ## Test Plan Follow dev README to setup the local editor: https://github.com/lastmile-ai/aiconfig/tree/main/python/src/aiconfig/editor#dev, then run this command ``` curl http://localhost:8080/api/run -d '{"prompt_name":"get_activities"}' -X POST -H 'Content-Type: application/json' ``` Without params https://github.com/lastmile-ai/aiconfig/assets/151060367/7233a4db-9042-4fa9-affb-0f854ae8a50e With params https://github.com/lastmile-ai/aiconfig/assets/151060367/6c078804-ea66-4358-824d-21d0fe26bafa
Victor-Su-Ortiz
pushed a commit
to Victor-Su-Ortiz/aiconfig
that referenced
this pull request
Jan 4, 2024
Not being used, let's get rid of it dawg! I also ran the linter based on Jonathan's command from this comment: lastmile-ai#613 (comment) ``` fd --glob '*.py' python/src/aiconfig/editor/server | xargs python -m 'scripts.lint' --mode=fix --files ``` ^ (btw you can install fd on Mac using `brew install fd`, looks pretty cool). It actually seems pretty cool https://github.com/sharkdp/fd?tab=readme-ov-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[editor][server endpoints][2/n]: Add params arg to run command and check for undefined prompt_name
TSIA, pretty simple otherwise we'd be using empty params field and that would error. For the future, I created issue #671 where we shouldn't even need to pass in params into run and this works implicitly
Test Plan
Follow dev README to setup the local editor: https://github.com/lastmile-ai/aiconfig/tree/main/python/src/aiconfig/editor#dev, then run this command
Without params
Screen.Recording.2024-01-02.at.12.55.58.mov
With params
Screen.Recording.2024-01-02.at.12.56.59.mov