Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Created get_parameters API #668

Merged
merged 1 commit into from
Jan 2, 2024
Merged

[python] Created get_parameters API #668

merged 1 commit into from
Jan 2, 2024

Commits on Jan 2, 2024

  1. [python] Created get_parameters API 

    **Disclaimer:** I know this is 400+ lines changed, but ~300 of those are just adding/refactoring automated tests!!!

We already had `get_prompt_parameters`, but this isn't good enough if parameters aren't defined locally and we want to bubble up to the aiconfig defaults. See comment in #661 (comment).

This is important so that we can ensure we have valid params if not defined in the correct section of our AIConfig schema. This is similar in theme to #600

The only callsite we have today for this is in python in the `params.py` function, so I updated that callsite too. I don't know why it doesn't exist in Typescript (cc @rholinshead) but I also added this functionality in typescript in #669 (I'm not as familiar with automated testing there so will ask Ryan for a code pointer to help get me started)

## Test plan
Added a bunch of automated tests which you can run by doing going to the `aiconfig/python` dir and running `pytest`
    Rossdan Craig rossdan@lastmileai.dev committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5a75379 View commit details
    Browse the repository at this point in the history