[1/n] Global parameters renderer #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saqadri
requested review from
rholinshead,
suyoglastmileai,
Ankush-lastmile,
jonathanlastmileai and
rossdanlm
as code owners
|
Test Plan: Screen.Recording.2023-12-29.at.1.35.38.PM.mov |
rholinshead
approved these changes
Dec 29, 2023
| initialValue, | ||
| onUpdateParameters, | ||
| }: Props) { | ||
| const [isParametersDrawerOpen, setIsParametersDrawerOpen] = useState(false); |
There was a problem hiding this comment.
What's the LOE to make this component UI into the card with bottom show/hide like in the figma -- https://www.figma.com/file/7YVa6KpEDgptj8DiAc5BaU/AiConfig-Editor?type=design&node-id=328-5037&mode=design&t=h3xAGY47py1mg4Fk-0 ?
There was a problem hiding this comment.
Probably not very high. I can do that as a follow-up next week
Use ParametersRenderer to modify global parameters. Currently still updating the entire parameters object. Next up, will fix the ParametersRenderer component to update each parameter separately.
This was referenced Dec 29, 2023
saqadri
added a commit
that referenced
this pull request
Dec 29, 2023
[easy] Simplify update parameters callback Have updateParameters take a JSONObject. Makes it much cleaner to use elsewhere. ParametersRenderer simply converts its ParametersArray to JSONObject before triggering the update. --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/674). * __->__ #674 * #673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1/n] Global parameters renderer
Use ParametersRenderer to modify global parameters.
Currently still updating the entire parameters object. Next up, will fix the ParametersRenderer component to update each parameter separately.