Make get_api_key_from_environment use Result-Ok
#787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 5, 2024 17:17
Sometimes key is not defined or set, we need to do this to unblock #769 The functionality is still unchanged because the optional param `required` defaults to true ## Test Plan Pass all automated tests (which it didn't before)
…call See comments from #772 (comment) ## Test Plan Run the Gemini cookbook to make sure it still works
Nice, cool tips from Jonathan Also deleted `test_config_util.py` because it wasn't being referenced anywhere
This was referenced Jan 5, 2024
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
jonathanlastmileai
approved these changes
Jan 5, 2024
rossdanlm
added a commit
that referenced
this pull request
Jan 5, 2024
…call (#786) Set the Gemini api key in init instead of re-running every inference call See comments from #772 (comment) ## Test Plan Run the Gemini cookbook to make sure it still works --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/786). * #787 * __->__ #786 * #772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
get_api_key_from_environmentuse Result-OkNice, cool tips from Jonathan
Also deleted
test_config_util.pybecause it wasn't being referenced anywhereStack created with Sapling. Best reviewed with ReviewStack.
get_api_key_from_environmentuse Result-Ok #787get_api_key_from_environmentreturn nullable #772