Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editor][client] render array objects in settings properly #902

Merged
merged 1 commit into from
Jan 12, 2024
Merged

[editor][client] render array objects in settings properly #902

merged 1 commit into from
Jan 12, 2024

Commits on Jan 12, 2024

  1. [editor][client] render array objects in settings properly 

    Upon loading the OpenAI function calling aiconfig, the editor client does not render the function data. This is because the functions are an array, and the client does not initialize array data.

In this diff, if the Settings data is an array with an initial value, properly set/intiailize and render the array data (inside SettingsPropertyRenderer)

Also updated the object renderer/settings to render json editor for an unspecified Json

## Testplan

Load the function calling aiconfig and open the model settings drawer. Notice the functions get rendered.

![testplan](https://github.com/lastmile-ai/aiconfig/assets/141073967/db69dd24-c792-43c1-9341-84eb235c007b)
    Ankush Pala ankush@lastmileai.dev committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    02b7c44 View commit details
    Browse the repository at this point in the history