7/n Read-only mode: Prompt Menu (Left side triple dots) #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ankush-lastmile
force-pushed
the
pr961
branch
from
e7739da
to
4e29c68
Compare
added 2 commits
January 18, 2024 13:28
- refactor `isReadonly` -> `readOnly` inside `ParametersRenderer.tsx`
- useState() to get readOnly bool
## Testplan
1. Pass readOnly=True prop in `AIConfigEditor`
| readOnly={false} | readOnly={true} |
| ------------- | ------------- |
| <img width="981" alt="Screenshot 2024-01-18 at 11 29 08 AM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/07747d6a-37d1-4b00-a5fb-ae8475c19044"> | <img width="1044" alt="Screenshot 2024-01-18 at 11 32 28 AM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/673abdb3-7048-444c-9ba2-8ad746181478"> |
## Dependencies
Built ontop of #939
- Add ReadOnly prop to the Prompt Menu (triple dots on the left side of the component)
## Testplan
1. Pass readOnly=True prop in `AIConfigEditor`
| readOnly={false} | readOnly={true} |
| ------------- | ------------- |
| <img width="1172" alt="Screenshot 2024-01-18 at 1 24 10 PM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/86842c3d-b864-45ef-bce4-77435c5d0518"> | <img width="1127" alt="Screenshot 2024-01-18 at 1 25 33 PM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/38c9ef53-dfe8-4eb8-b7f2-5f87adf2a708"> |
Ankush-lastmile
force-pushed
the
pr961
branch
from
4e29c68
to
985aad8
Compare
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
rossdanlm
approved these changes
Jan 18, 2024
rholinshead
approved these changes
Jan 18, 2024
Ankush-lastmile
pushed a commit
that referenced
this pull request
Jan 18, 2024
- refactor `isReadonly` -> `readOnly` inside `ParametersRenderer.tsx`
- useState() to get readOnly bool
## Testplan
1. Pass readOnly=True prop in `AIConfigEditor`
| readOnly={false} | readOnly={true} |
| ------------- | ------------- |
| <img width="981" alt="Screenshot 2024-01-18 at 11 29 08 AM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/07747d6a-37d1-4b00-a5fb-ae8475c19044"> | <img width="1044" alt="Screenshot 2024-01-18 at 11 32 28 AM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/673abdb3-7048-444c-9ba2-8ad746181478"> |
## Dependencies
Built ontop of #939
#961 is next on the stack
Ankush-lastmile
added a commit
that referenced
this pull request
Jan 19, 2024
[easy][editor][client] 6/n Read-only mode: Global Parameters
- refactor `isReadonly` -> `readOnly` inside `ParametersRenderer.tsx`
- useState() to get readOnly bool
## Testplan
1. Pass readOnly=True prop in `AIConfigEditor`
| readOnly={false} | readOnly={true} |
| ------------- | ------------- |
| <img width="981" alt="Screenshot 2024-01-18 at 11 29 08 AM"
src="https://github.com/lastmile-ai/aiconfig/assets/141073967/07747d6a-37d1-4b00-a5fb-ae8475c19044">
| <img width="1044" alt="Screenshot 2024-01-18 at 11 32 28 AM"
src="https://github.com/lastmile-ai/aiconfig/assets/141073967/673abdb3-7048-444c-9ba2-8ad746181478">
|
## Dependencies
Built ontop of #939
#961 is next on the stack
---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with
[ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/967).
* #962
* __->__ #967
Ankush-lastmile
pushed a commit
that referenced
this pull request
Jan 19, 2024
Attempted to add read-only functionality wherever applicable to input renderings. ## Testplan |  |  | | --- | --- | |  |  | |  |  | |  |  | ## dependencies built ontop of #961
Ankush-lastmile
pushed a commit
that referenced
this pull request
Jan 19, 2024
Attempted to add read-only functionality wherever applicable to input renderings. ## Testplan |  |  | | --- | --- | |  |  | |  |  | |  |  | ## dependencies built ontop of #961
Ankush-lastmile
pushed a commit
that referenced
this pull request
Jan 19, 2024
Attempted to add read-only functionality wherever applicable to input renderings. ## Testplan |  |  | | --- | --- | |  |  | |  |  | |  |  | ## dependencies built ontop of #961
Ankush-lastmile
added a commit
that referenced
this pull request
Jan 19, 2024
8/n Read-only mode: Input rendering Attempted to add read-only functionality wherever applicable to input renderings. ## Testplan |  |  | | --- | --- | |  |  | |  |  | |  |  | ## dependencies built ontop of #961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7/n Read-only mode: Prompt Menu (Left side triple dots)
Testplan
AIConfigEditorStack created with Sapling. Best reviewed with ReviewStack.