3/n add to model parser registry on init #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 19, 2024
added 3 commits
January 25, 2024 00:55
- This diff copy pastes the source code for the Gemini Model parser. - - Removed the the auto register to model parser - doesn't link with the sdk in any way. Just makes class importable. Trying to import this will break/throw. - more to come on top Taken from extensions/gemini/gemini.py.
title Part of a diff stack to incorporate Gemini in the core sdk.
- add Gemini Parser to Model Parser Registry - reorganize imports to avoid circular dependency imports ## Testplan <img width="1554" alt="Screenshot 2024-01-25 at 1 06 03 AM" src="https://github.com/lastmile-ai/aiconfig/assets/141073967/54157e31-76ea-49a1-bbd3-f96e6ef7d71f">
Ankush-lastmile
force-pushed
the
pr987
branch
from
e0e8f7f
to
37cef99
Compare
Ankush-lastmile
requested review from
saqadri,
rholinshead,
suyoglastmileai,
jonathanlastmileai and
rossdanlm
as code owners
rholinshead
reviewed
Jan 26, 2024
Comment on lines
+59
to
+60
| ModelParserRegistry.register_model_parser(PaLMChatParser()) | ||
| ModelParserRegistry.register_model_parser(PaLMTextParser()) |
There was a problem hiding this comment.
Maybe we can axe PaLM registry by default soon?
rholinshead
approved these changes
Jan 26, 2024
Yea, we need to figure out what our gameplan is for having a model as core or not. It does use the api dependency as Gemini though so that's something to think about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/n add to model parser registry on init
Testplan
Stack created with Sapling. Best reviewed with ReviewStack.