Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Plugin Provider, Name and Id should be cleaned up #19

Closed
vorburger opened this issue Sep 15, 2017 · 3 comments
Closed

Feature/Plugin Provider, Name and Id should be cleaned up #19

vorburger opened this issue Sep 15, 2017 · 3 comments

Comments

@vorburger
Copy link
Member

vorburger commented Sep 15, 2017

Both the Feature's & Plugin's Provider, Name and Id should be cleaned up:

  • Provider: lastnpe.org instead of Sylvain & my name
  • Provider in "Installed Software" (feature.feature.group) is empty
  • Name: Something copy/pasted from somewhere around here, instead of "Maven Integration for Eclipse Settings"
  • Id: org.lastnpe.m2e.feature instead of eclipse_external_annotations_m2e_plugin

@sylvainlaurent is this something you may be interested in doing?

@vorburger
Copy link
Member Author

Note to self: When feature's ID changes, adjust here accordingly.

@sylvainlaurent
Copy link
Member

@vorburger OK for provider and name.
But are you sure you want to change the Id ? it would also require to change the groupId and artifactId in the various pom.xml. For instance org.lastnpe.m2e for groupId, but what for artifactId?

@vorburger
Copy link
Member Author

vorburger commented Nov 14, 2017

done! Thanks a lot @sylvainlaurent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants