Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort list of source files #214

Merged
merged 1 commit into from
Nov 2, 2016
Merged

Sort list of source files #214

merged 1 commit into from
Nov 2, 2016

Conversation

reinerh
Copy link
Contributor

@reinerh reinerh commented Nov 1, 2016

$(wildcard) does not guarantee a sorted list, which causes
also a non-deterministic order while linking the binary.
To support reproducible building, the list is explicitely sorted.

@bcopeland
Copy link
Contributor

I'd like to take this patch and support reproducible building in general, but please note:

  • I need a signed-off-by to apply (see CONTRIBUTING)
  • There's a pending branch to convert everything to cmake. I presume something like this would still beuseful there though.

$(wildcard) does not guarantee a sorted list, which causes
also a non-deterministic order while linking the binary.
To support reproducible building, the list is explicitely sorted.

Signed-off-by: Reiner Herrmann <reiner@reiner-h.de>
@reinerh
Copy link
Contributor Author

reinerh commented Nov 1, 2016

Just amended the commit with a signed-off-by.

For cmake probably no further change is required.
I see that you are using file(GLOB ...) there, which could be sorted with list(SORT ...), but a patch for cmake is already pending (not sure if it's released yet), which guarantees a sorted order in file(GLOB ...), see:
https://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=edcccde7

@bcopeland bcopeland merged commit f77c56d into lastpass:master Nov 2, 2016
@bcopeland
Copy link
Contributor

Thanks - any other patches needed for reproducible builds are more than welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants