generate: fix type for option parsing #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
char may or may not be signed depending on architecture. If char is unsigned on a given architecture, then will the testing the return value from getopt_long (which is int) always fail. This happened on some architectures like ppc64le, aarch64 and s390x. To fix this we use same type as getopt_long return value: int. fixes lastpass#345 Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
|
Nice find - I was scratching my head at the bug report since I didn't see any endian-sensitive options in the generate command. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
char may or may not be signed depending on architecture. If char is
unsigned on a given architecture, then will the testing the return value
from getopt_long (which is int) always fail. This happened on some
architectures like ppc64le, aarch64 and s390x.
To fix this we use same type as getopt_long return value: int.
fixes #345
Signed-off-by: Natanael Copa ncopa@alpinelinux.org