Force IPv4 for every curl call made to lastpass API servers #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users with IPv6 enabled report slowness due to IPv6. The default of Curl is to look at both IPv6 and IPv4. This quickfix makes it possible for users to not experience these issues. We may need to do this differently by enabling lpass -4 to force IPv4 and -6 for v6. Fixes: lastpass#440, lastpass#475 Signed-off-by: Wesley Schwengle <wesley@schwengle.net>
|
After a little digging and talking with DevOPS it is totally possible that lastpass.com will not work with IPv6. So until it is confirmed that its fixed I'll merge this, and once we introduce IPv6 we can think about how to handle both IPv4 and IPv6. Thank You @waterkip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users with IPv6 enabled report slowness due to IPv6. The default of Curl
is to look at both IPv6 and IPv4. This quickfix makes it possible for
users to not experience these issues. We may need to do this differently
by enabling lpass -4 to force IPv4 and -6 for v6.
Fixes: #440, #475
Signed-off-by: Wesley Schwengle wesley@schwengle.net