Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabularray broken with latest release of l3kernel #1458

Closed
ArchangeGabriel opened this issue Feb 15, 2024 · 7 comments
Closed

tabularray broken with latest release of l3kernel #1458

ArchangeGabriel opened this issue Feb 15, 2024 · 7 comments
Labels
bug Something isn't working report-elsewhere Valid but not for the latex3 repository

Comments

@ArchangeGabriel
Copy link

After upgrading my TeX Live install today, which included https://tug.org/svn/texlive?revision=69870&view=revision, I’m facing an error compiling any document that use tabularray:

(/usr/local/texlive/2023/texmf-dist/tex/latex/tabularray/tabularray.sty
(/usr/local/texlive/2023/texmf-dist/tex/latex/l3kernel/expl3.sty
(/usr/local/texlive/2023/texmf-dist/tex/latex/l3backend/l3backend-luatex.def))
! Undefined control sequence.
<argument> \g__tblr_defined_hdash_styles_prop 
                                   
l.1089 ...yval:Nn \g__tblr_defined_hdash_styles_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_defined_vdash_styles_prop 
                                   
l.1091 ...yval:Nn \g__tblr_defined_vdash_styles_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_table_prop 
                            
l.2956 ...from_keyval:Nn \g__tblr_initial_table_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_rows_prop 
                           
l.2962 ..._from_keyval:Nn \g__tblr_initial_rows_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_columns_prop 
                              
l.2973 ...om_keyval:Nn \g__tblr_initial_columns_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_cells_prop 
                            
l.2982 ...from_keyval:Nn \g__tblr_initial_cells_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_hlines_prop 
                             
l.2992 ...rom_keyval:Nn \g__tblr_initial_hlines_prop
                                                  
? 
! Undefined control sequence.
<argument> \g__tblr_initial_vlines_prop 
                             
l.2997 ...rom_keyval:Nn \g__tblr_initial_vlines_prop
                                                  
? 
)

I’ve also reported it at lvjr/tabularray#474 in case it should be fixed there.

@josephwright
Copy link
Member

The error is right in the sense \g__tblr_defined_hdash_styles_prop is undefined at that point: the current code in tabularray is trying to use (e.g.) \prop_gset_from_keyval:Nn without first declaring the variable.That's never been supported: it's just that internal changes make it an error. It would always have been flagged up if loading the debug setup.

I'll leave open for the moment, but really this needs to be fixed in tabularray.

@josephwright josephwright added bug Something isn't working report-elsewhere Valid but not for the latex3 repository labels Feb 15, 2024
@u-fischer
Copy link
Member

u-fischer commented Feb 15, 2024

It would always have been flagged up if loading the debug setup.

@josephwright Was that really catched by the debug setup? I don't get an error in older systems with

\ExplSyntaxOn
\debug_on:n { check-declarations , deprecation }
\ExplSyntaxOff

\documentclass{article}
\begin{document}
\ExplSyntaxOn
\prop_gset_from_keyval:Nn \g_blub_prop{a=b}
\ExplSyntaxOff    
\end{document}

@josephwright
Copy link
Member

@u-fischer That would be an omission in the debug module, but the point still stands: we do require declaration before use in general (exception: variables used to store keys are 'auto-generated').

josephwright added a commit that referenced this issue Feb 15, 2024
See #1458: this was intended to be covered by \prop_(g)put_from_keyval:Nn, but the move to linked-lists negates that.
@josephwright
Copy link
Member

@u-fischer I've fixed that issue - I think it was picked up immediately before the latest update, but not long before that so likely could be missed.

@u-fischer
Copy link
Member

u-fischer commented Feb 15, 2024

@josephwright acro is affected too and there it is \prop_clear:N which was not caught by the debug option (and now errors):

\ExplSyntaxOn
\debug_on:n { check-declarations , deprecation }
\ExplSyntaxOff

\documentclass{article}
\begin{document}
\ExplSyntaxOn
\prop_clear:N \l_blub_prop
\ExplSyntaxOff    
\end{document}

@josephwright
Copy link
Member

@u-fischer I guess \prop_clear:N somehow got missed in debugging too :(

@muzimuzhi
Copy link
Collaborator

This is solved with tabularray 2024A (2024-02-16), see lvjr/tabularray@0060844, corresponding CTAN announcement, and TeX Live svn r69926.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working report-elsewhere Valid but not for the latex3 repository
Projects
None yet
Development

No branches or pull requests

4 participants