Fix string formatting of version number #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. I think I would prefer a |
According to Lua 5.3 manual %q is for formatting strings and escaping them so that they can be read again by Lua. This particular number is however floating point and %q chooses to format it like with %a, that means hexadecimal. This greatly reduces the the readability. Because ConTeXt's OpenType loader versions are always in the format `x.yyy` we can use %.3f directly. This is the difference in output: ``` luaotfload | init : Context OpenType loader version 0x1.8e76c8b439581p+1 luaotfload | init : Context OpenType loader version 3.113 ``` There may be other places where this issue may be relevant, but this line is printed to every log file.
|
Yeah, you are right, on second thought Initally I was going for the more general "human readable" approach of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Lua 5.3 manual %q is for formatting strings and escaping
them so that they can be read again by Lua. This particular number is
however floating point and %q chooses to format it like with %a, that
means hexadecimal. This greatly reduces the the readability. Better
option seems to be using %s, which uses
tostringfunction.This is the difference in output:
There may be other places where this issue may be relevant, but this
line is printed to every log file.
Most of the tests failed on me, but it doesn't seem to be a problem
with this patch.
If you choose to accept this PR consider rebase merging.