Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multicol breaks float code #705

Closed
u-fischer opened this issue Sep 10, 2024 · 0 comments
Closed

multicol breaks float code #705

u-fischer opened this issue Sep 10, 2024 · 0 comments
Assignees
Labels
area: output routine bug Something isn't working in code we maintain (directly)

Comments

@u-fischer
Copy link
Member

The multicol package redefines inside the multicols environment \end@dblfloat and this breaks the handling of double column floats. They produce warnings and circular parent-kid references and the floats are lost.

This here seems to fix it. The kernel should provide tagging sockets, so that multicol can add them:

\DocumentMetadata{%
	%pdfstandard=A-4f,
	pdfversion=2.0,
	lang=en,
	testphase={phase-III},
    uncompress
}
\documentclass{article}
\usepackage{multicol}
\makeatletter
\def\set@floatcmds{%
 \let\@dblfloat\@dbflt
 \def\end@dblfloat{\@endfloatbox
   \@nameuse{__tag_float_end:}%missing
   \@largefloatcheck
   \outer@nobreak
   \ifnum\@floatpenalty<\z@
     \@cons\@deferlist\@currbox
   \fi
   \ifnum\@floatpenalty=-\@Mii
     \@Esphack
     \@nameuse{__tag_float_start_par:}%missing
   \fi}}
\begin{document}
\begin{multicols}{2}
hallo

\begin{table*}
a large table
\end{table*}
Welt
\end{multicols}
\end{document}
@FrankMittelbach FrankMittelbach added area: output routine bug Something isn't working in code we maintain (directly) labels Sep 12, 2024
@FrankMittelbach FrankMittelbach self-assigned this Sep 12, 2024
u-fischer added a commit to latex3/latex2e that referenced this issue Sep 13, 2024
@u-fischer u-fischer added fixed in branch fixed in a branch different to develop labels Sep 18, 2024
u-fischer added a commit to latex3/latex2e that referenced this issue Sep 24, 2024
…branch)

* switch to tagging sockets in float module, WIP

* use tagging socket in multicol, latex3/tagging-project#705

* luatex test

* improve autoref compability

* WIP, use sockets for caption

* better documentation of plugs

* use sockets for caption, WIP

* small corrections, flattened par

* update testfiles

* correct brace

* caption sockets

* switch to tag_suspend/tag_resume

* some more docu

* testfile latex3/tagging-project#13

* correct date

* correct wording

* wrong number

* extend todos
@u-fischer u-fischer added fixed in release issue is fixed and will be deployed in the next release of package or kernel and removed fixed in branch fixed in a branch different to develop labels Sep 24, 2024
@FrankMittelbach FrankMittelbach removed the fixed in release issue is fixed and will be deployed in the next release of package or kernel label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: output routine bug Something isn't working in code we maintain (directly)
Projects
None yet
Development

No branches or pull requests

2 participants