feat(evaluation): evaluation results in UI #631
Conversation
geclos
force-pushed
the
feature/hitl_evaluations_in_ui
branch
5 times, most recently
from
201590a
to
451374b
Compare
geclos
force-pushed
the
feature/hitl_evaluations_in_ui
branch
from
451374b
to
86e66d0
Compare
Is this one? |
| <Text.H4 noWrap> | ||
| {typeof value === 'string' && value.length > 30 | ||
| ? `${value.slice(0, 30)}...` | ||
| : (value as string)} |
There was a problem hiding this comment.
Wait. This should not be necessary. Review the CSS it can be done with ellipsis prop in this text + a wrap div. Look for text examples with ellipsis
There was a problem hiding this comment.
i think it's because it's a table element
There was a problem hiding this comment.
what i mean is that in order for it to work i would have to put a max width limit to the wrapper div which ends up being the same hardcoding
...uationId]/_components/ManualEvaluationResults/DocumentLogInfo/BaseEvaluationResult/index.tsx
Outdated
Show resolved
Hide resolved
- Introduced new components for manual evaluation results submission, including boolean, number, and text types. - Updated `EvaluationResults` to handle manual evaluations separately from automated ones. - Added new API routes to fetch document logs with evaluation results. - Implemented new hooks and stores for managing evaluation results and document logs with evaluation results. - Modified existing components to support the new manual evaluation flow. - Updated serialization logic for provider logs to accommodate evaluation-specific requirements. - Enhanced the evaluation results update process to include reason updates and event publishing. This change allows users to manually submit evaluation results, providing more flexibility and control over the evaluation process.
geclos
force-pushed
the
feature/hitl_evaluations_in_ui
branch
3 times, most recently
from
736cab2
to
019eca7
Compare
| ) | ||
| } | ||
| className={cn( | ||
| 'cursor-pointer border-b-[0.5px] h-12 max-h-12 border-border', |
There was a problem hiding this comment.
I.... don't remember 😂 but there's a reason
| @@ -18,6 +20,8 @@ export default function TotalsPanels({ | |||
| documentUuid: string | |||
| evaluationId: number | |||
| }) { | |||
| const { data: evaluations } = useEvaluations() | |||
| const evaluation = evaluations.find((e) => e.id === evaluationId) | |||
There was a problem hiding this comment.
very small n it's negligible
geclos
force-pushed
the
feature/hitl_evaluations_in_ui
branch
from
019eca7
to
f62fffd
Compare
| return Result.error(new NotFoundError('Workspace not found')) | ||
| } | ||
|
|
||
| publisher.publishLater({ |
There was a problem hiding this comment.
If the transaction is rollback this will be send anyway?
There was a problem hiding this comment.
yeah we still have this issue
There was a problem hiding this comment.
Why not this?
const result = Transaction.call(
// Things....
)
if (result.error) return result
publisher.publishLater...
return result
EvaluationResultsto handle manual evaluations separately from automated ones.This change allows users to manually submit evaluation results, providing more flexibility and control over the evaluation process.