Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: publish docker image #1398

Merged
merged 25 commits into from
Sep 6, 2023
Merged

build: publish docker image #1398

merged 25 commits into from
Sep 6, 2023

Conversation

holic
Copy link
Member

@holic holic commented Sep 5, 2023

This should publish an image for every main commit, tagged with latest (for main branch), branch name, and sha. You can also manually kick off an image build/push via workflow trigger.

https://github.com/orgs/latticexyz/packages
image

Some improvements for later:

  • always build Docker image on every commit, only push on the branches we want to release from

  • add version tag, but requires Changesets allowing is to have one git tag per version rather than one per package+version: Allow disabling tags or creating single tag changesets/changesets#589

    possibly fixed with a regex tag! will need to release before we can tell if this works

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

⚠️ No Changeset found

Latest commit: 097352b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic holic changed the title WIP publish docker image feat: publish docker image Sep 5, 2023
@holic holic changed the title feat: publish docker image build: publish docker image Sep 5, 2023
@holic
Copy link
Member Author

holic commented Sep 5, 2023

it works! still not sure why the sha tag isn't working but I am hoping it'll work once this lands

@holic holic marked this pull request as ready for review September 5, 2023 13:00
@holic holic requested a review from alvrs as a code owner September 5, 2023 13:00
@holic holic merged commit 8b33685 into main Sep 6, 2023
@holic holic deleted the holic/dockerfile-ci branch September 6, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants