Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add prototypes to tablegen #506

Closed
wants to merge 1 commit into from
Closed

feat(cli): add prototypes to tablegen #506

wants to merge 1 commit into from

Conversation

dk1a
Copy link
Contributor

@dk1a dk1a commented Mar 17, 2023

Simplified replacement for #459
(this is just prototypes now, without all the unrelated refactoring/fixes, which were done in #500)

@dk1a dk1a requested review from alvrs and holic as code owners March 17, 2023 14:16
@dk1a dk1a mentioned this pull request Mar 24, 2023
Open
47 tasks
@ludns ludns mentioned this pull request Mar 29, 2023
Open
@alvrs alvrs marked this pull request as draft April 11, 2023 13:51
@alvrs
Copy link
Member

alvrs commented Apr 11, 2023

Context: we discussed moving this feature into a plugin, which means merging is blocked on a plugin API. Marking this PR a draft for now.

@alvrs
Copy link
Member

alvrs commented Jun 12, 2023

Closing this for now since it's out of date. Once modules/plugins are in a stable state we should add a plugin for this (@yonadaaa was working on something similar in #749)

@alvrs alvrs closed this Jun 12, 2023
@holic holic deleted the dk1a/tablegen-prototypes branch June 23, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

@holic holic Awaiting requested review from holic holic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dk1a @alvrs