Skip to content
This repository was archived by the owner on Jul 25, 2022. It is now read-only.

Move configuration to the Scala code #29

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

Jarlakxen
Copy link
Contributor

No description provided.

@laughedelic
Copy link
Owner

Hi @Jarlakxen! I like the intent to "Move configuration to the Scala code", but I was actually working on a more generic and more typed solution for it. It would be better to coordinate work to avoid extra effort or unmerged PRs, so let's discuss whatever you have in mind in the chat or in a dedicated issue next time.

I'm going to try it out and merge if it works fine, because it's an improvement over the current state anyway.

Copy link
Owner

@laughedelic laughedelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played a bit with the code here and to be honest, I expected that this will allow you to query settings using this configuration in code, but it doesn't 😢

It's still an improvement, because when you change something in configuration, you don't need to reload sbt, you can just recompile the code 👍

Merging!

@laughedelic laughedelic merged commit 1cbd2c5 into laughedelic:master Jan 29, 2018
@laughedelic laughedelic added this to the BIG release milestone Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants