fix and test handling of 0 for BigDecimal in Postgres/MySQL

closes #283
launchbadge · Apr 27, 2020 · 6102a63 · 6102a63
1 parent 3e2ed00
commit 6102a63
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/sqlx-core/src/postgres/types/bigdecimal.rs b/sqlx-core/src/postgres/types/bigdecimal.rs
@@ -122,8 +122,12 @@ impl TryFrom<PgNumeric> for BigDecimal {
             }
         };
 
+        if digits.is_empty() {
+            // Postgres returns an empty digit array for 0 but BigInt expects at least one zero
+            return Ok(0u64.into());
+        }
+
         let sign = match sign {
-            _ if digits.is_empty() => Sign::NoSign,
             PgNumericSign::Positive => Sign::Plus,
             PgNumericSign::Negative => Sign::Minus,
         };

diff --git a/tests/mysql-types.rs b/tests/mysql-types.rs
@@ -128,6 +128,7 @@ mod time_tests {
 test_type!(decimal(
     MySql,
     sqlx::types::BigDecimal,
+    "CAST(0 as DECIMAL(0, 0))" == "0".parse::<sqlx::types::BigDecimal>().unwrap(),
     "CAST(1 AS DECIMAL(1, 0))" == "1".parse::<sqlx::types::BigDecimal>().unwrap(),
     "CAST(10000 AS DECIMAL(5, 0))" == "10000".parse::<sqlx::types::BigDecimal>().unwrap(),
     "CAST(0.1 AS DECIMAL(2, 1))" == "0.1".parse::<sqlx::types::BigDecimal>().unwrap(),

diff --git a/tests/postgres-types.rs b/tests/postgres-types.rs
@@ -166,6 +166,8 @@ test_prepared_type!(numeric(
 test_type!(decimal(
     Postgres,
     sqlx::types::BigDecimal,
+    // https://github.com/launchbadge/sqlx/issues/283
+    "0::numeric" == "0".parse::<sqlx::types::BigDecimal>().unwrap(),
     "1::numeric" == "1".parse::<sqlx::types::BigDecimal>().unwrap(),
     "10000::numeric" == "10000".parse::<sqlx::types::BigDecimal>().unwrap(),
     "0.1::numeric" == "0.1".parse::<sqlx::types::BigDecimal>().unwrap(),