Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Postgres' Length Limit for Bind Parameters #1141

Merged
merged 2 commits into from
Mar 30, 2021
Merged

Correct Postgres' Length Limit for Bind Parameters #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e0adf5
Bump limit for postgres' bind parameters
crajcan Mar 28, 2021
f2ca870
Fix lingering fmt error
crajcan Mar 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sqlx-core/src/postgres/message/parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ impl Encode<'_> for Parse<'_> {
buf.put_str_nul(self.query);

// TODO: Return an error here instead
assert!(self.param_types.len() <= (i16::MAX as usize));
assert!(self.param_types.len() <= (u16::MAX as usize));

buf.extend(&(self.param_types.len() as i16).to_be_bytes());

Expand Down
4 changes: 2 additions & 2 deletions tests/sqlite/derives.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ use sqlx_test::{new, test_type};
#[derive(Debug, PartialEq, sqlx::Type)]
#[repr(u32)]
enum Origin {
Foo = 1,
Bar = 2,
Foo = 1,
Bar = 2,
}

test_type!(origin_enum<Origin>(Sqlite,
Expand Down