Remove Self: Type
bounds in Encode / Decode implementations
#1170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes on the first commit:
panic!
s behaviors. I'm assuming not using a format string there was an oversight, rather than those panics really being meant to be catch-able asstd::io::Error
s.enter_runtime
for tokio was actually wrong before, due to the runtime guard being dropped before calling the function argument.About the second ("main") commit: I've only tested that the change of the slice implementation doesn't result in compilation errors, nothing more.