Drop worker shared state in shutdown (Sqlite) #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
|
It would be nice to have a unit test to check this behaviour, but I haven't found a good way to do it yet. Essentially I think it would need to close the database and then immediately try to delete it to show that the close has completed properly, which would probably mean opening a database in the system temp directory (with a known filename). Alternatively I suppose it could check for the presence of a .shm or .wal file after the database is meant to be closed? In any case I've only been able to reproduce the issue on Windows on Github Actions so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to previous issue #1452