Make all ConnectOptions clonable #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05storm26
force-pushed
the
clonable_connect_options
branch
from
2d5ba5e
to
b4e6df0
Compare
|
(I think, this will need to be rebased after #1610 and needs a simple conflict resolve) |
05storm26
force-pushed
the
clonable_connect_options
branch
2 times, most recently
from
e4b2eae
to
63685d0
Compare
|
@abonander When can you merge this? Is this going to be in 0.6? |
05storm26
force-pushed
the
clonable_connect_options
branch
from
63685d0
to
12f2cbc
Compare
|
I rebased this on master and resolved the conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all
ConnectOptionsimplementation areClone. I think this will continue to be true, and it might be useful to give this guarantee in general.