-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: alias actix-* features to their equivalent tokio-* features #1679
Conversation
Test failures look similar to master's failures so doesn't appear like this broke anything. |
It's also definitely possible to run fewer CI checks now, but I would leave that to a follow up PR, leaving this one to prove that they are equivalent. |
The reason we've kept the Whether we keep the aliases or not going forward depends on how clear Actix-web wants to be about its interoperability with Tokio. While there's obviously no intent to hide Tokio, there's also nothing that, based on our experiences, states it clearly enough for a naive user to understand that Actix-web works on Tokio. For example: The release-candidate docs still show using The README mentions "Full Tokio compatbility" but doesn't elaborate on what that means, and it's not mentioned at all in the otherwise identical list of features in the crate docs. The docs for The docs for I do agree, however, that it doesn't make sense to have a separate set of CI passes just for Actix, although I could also see a naive user complaining that Actix isn't covered in CI if we don't have them, so it still comes back around to Actix-web's messaging on the matter. |
Appreciate the perspective on clarity wrt relationship with Tokio. I'll make some changes to the docs. No rush removing the actix-* flags or CI checks until you're happy. |
Actix Web v4 is released and I think the messaging on the relationship with Tokio is a lot clearer in the docs now. |
@abonander you or someone else on the team available for review? |
actix- runtime feature flags are now aliases for tokio- flags
Rebased. I still think it's a good idea to simplify these. |
Actix Web v4 is stable and finally works under
#[tokio::main]
/#[tokio::test]
. Therefore, I think it's safe to "remove" these feature flags now. They haven't actually been doing anything more than tokio- flags for a while.I thought that removing the private flags and aliasing the public ones to their tokio- equivalent would be the best migration path. That way this could go out in a non-breaking release.
Inspired by #1669.